Repository navigation
ci: remove Snyk scan and monitor - #1142
Conversation
Signed-off-by: Bruno De Assis Marques <bruno.marques@swirldslabs.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
🟢 Approval recommended
Repository-wide searches confirm every Snyk job, input, secret, and caller reference was fully removed with no orphaned references and all edited workflows parse as valid YAML.
No open issues 🎉
What changed in this PR
This PR removes Snyk from CI as part of its decommissioning across the hiero-ledger, hashgraph, and swirldslabs organizations (closes #1141). It deletes the standalone Snyk monitor workflow and strips all Snyk-related jobs, steps, inputs, and secrets from the reusable code-analysis workflow and its callers, leaving Sonar and CodeCov analysis intact.
Changes:
- Delete the
ZXF: Snyk Monitorworkflow entirely. - Remove the
Snyk Scanjob from PR checks and the Snyk steps/enable-snyk-scaninput/snyk-tokensecret from the reusable code-analysis workflow. - Stop passing
enable-snyk-scanandSNYK_TOKENfrom the build workflow and drop itsenable-snyk-scandispatch input.
| File | Description |
|---|---|
.github/workflows/zxf-snyk-monitor.yaml |
Deleted; removes the scheduled/push-triggered Snyk monitor job. |
.github/workflows/zxc-code-analysis.yaml |
Removes the enable-snyk-scan input, snyk-token secret, all Snyk steps, and updates the Node setup comment. |
.github/workflows/flow-pull-request-checks.yaml |
Removes the Snyk Scan job that invoked the analysis workflow with Snyk enabled. |
.github/workflows/flow-build-application.yaml |
Drops the enable-snyk-scan dispatch input and stops passing it plus SNYK_TOKEN to the analysis workflow. |
Review effort: Balanced
1266e3b to
45913d8
Compare
Co-authored-by: brunodam <83957476+brunodam@users.noreply.github.com>
Description
Snyk is being decommissioned across the hiero-ledger, hashgraph, and swirldslabs organizations. This removes it from CI here.
This pull request changes the following:
zxf-snyk-monitor.yamlSnyk Scanjob fromflow-pull-request-checks.yamlenable-snyk-scaninput, and thesnyk-tokensecret fromzxc-code-analysis.yaml; Sonar and CodeCov analysis are unchangedenable-snyk-scanandSNYK_TOKENfromflow-build-application.yaml, and drop itsenable-snyk-scandispatch inputEdited workflows parse as YAML, and
actionlintreports no new findings on them. No ruleset requires a Snyk check in this repository.Related Issues